Repository navigation
Conversation
Signed-off-by: Yi Zhan <stevesough@gmail.com>
✅ Deploy Preview for cookieconsentv3-playground canceled.
|
|
@Steve0x2a is attempting to deploy a commit to the Orest Bida's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lazyHtmlGenerationis documented as delaying modal markup until a modal is about to become visible, butgenerateHtmlalways built the consent modal whenever consent was invalid. WithautoShow: falsethat left an unusedrole="dialog"in the document.Gate
createConsentModalonlazyHtmlGenerationthe same way as the preferences modal.show()still creates the consent modal when consent is invalid, soCookieConsent.show()continues to work.Credits @okadriu for the report and the named
generateHtmlpath.Fixes #830